Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(ZoneBudget6): Added ZoneBudget6 class to zonbud.py #1149

Merged
merged 4 commits into from
Jul 12, 2021
Merged

Feat(ZoneBudget6): Added ZoneBudget6 class to zonbud.py #1149

merged 4 commits into from
Jul 12, 2021

Conversation

jlarsen-usgs
Copy link
Contributor

  • moved shared methods to hidden definitions from ZoneBudget class
  • begin deprecation of ZoneBudgetOutput class
  • added .zonebudget() to the .output method for modflow6

@jlarsen-usgs
Feat(ZoneBudget6): Added ZoneBudget6 class to zonbud.py
f271a0b 
* moved shared methods to hidden definitions from ZoneBudget class
* begin deprecation of ZoneBudgetOutput class
* added .zonebudget() to the .output method for modflow6
@jlarsen-usgs
try moving import to local for python 3.6 errors
4aee601
@jlarsen-usgs
linting
933b546
@codecov
Copy link

codecov bot commented Jul 10, 2021 •
edited
Loading

Codecov Report

Merging #1149 (60b5b19) into develop (3924e6e) will decrease coverage by 72.269%.
The diff coverage is 0.000%.

❗ Current head 60b5b19 differs from pull request most recent head 927d6a2. Consider uploading reports for the commit 927d6a2 to get more accurate results

@@              Coverage Diff              @@
##           develop    #1149        +/-   ##
=============================================
- Coverage   72.269%   0.000%   -72.270%     
=============================================
  Files          227      227                
  Lines        52292    52581       +289     
=============================================
- Hits         37791        0     -37791     
- Misses       14501    52581     +38080
Impacted Files Coverage Δ
flopy/discretization/modeltime.py 0.000% <0.000%> (-88.889%) ⬇️
flopy/mf6/utils/binarygrid_util.py 0.000% <0.000%> (-86.336%) ⬇️
flopy/mf6/utils/output_util.py 0.000% <0.000%> (-67.176%) ⬇️
flopy/utils/__init__.py 0.000% <ø> (-100.000%) ⬇️
flopy/utils/zonbud.py 0.000% <ø> (-89.699%) ⬇️
flopy/version.py 0.000% <0.000%> (-100.000%) ⬇️
flopy/__init__.py 0.000% <0.000%> (-100.000%) ⬇️
flopy/pest/params.py 0.000% <0.000%> (-100.000%) ⬇️
flopy/mf6/__init__.py 0.000% <0.000%> (-100.000%) ⬇️
flopy/mt3d/__init__.py 0.000% <0.000%> (-100.000%) ⬇️
... and 218 more

@jdhughes-usgs jdhughes-usgs self-requested a review July 12, 2021 18:36
jdhughes-usgs
jdhughes-usgs approved these changes Jul 12, 2021
View reviewed changes
Copy link
Contributor

@jdhughes-usgs jdhughes-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlarsen-usgs this looks good is it ready to be merged?

@jlarsen-usgs
Copy link
Contributor Author

@jdhughes-usgs

This is ready to be merged

@jdhughes-usgs jdhughes-usgs merged commit 04fe7e4 into modflowpy:develop Jul 12, 2021
This was referenced Jul 27, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdhughes-usgs jdhughes-usgs jdhughes-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlarsen-usgs @jdhughes-usgs